Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: lower log level to debug #960

Merged
merged 1 commit into from
Jan 2, 2025
Merged

refactor: lower log level to debug #960

merged 1 commit into from
Jan 2, 2025

Conversation

npepinpe
Copy link
Member

Description

This PR lowers the log level of the initial engine creation log statement. The reasoning here is that almost all of the information provided here is only really useful for debugging, and generally not useful for the common user.

As this is mostly to reduce the noise-to-signal ratio in Zeebe, the alternative would be only showing WARN messages from this library (as we do with other libraries). That would also be acceptable to me, so feel free to reject this if you disagree, and we can go with the alternative :)

Related issues

closes camunda/camunda#26395

Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@npepinpe LGTM. 👍

@saig0 saig0 added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 3d058a0 Jan 2, 2025
5 checks passed
@saig0 saig0 deleted the np-26395-lower-log-level branch January 2, 2025 13:11
@saig0
Copy link
Member

saig0 commented Jan 3, 2025

/backport

@saig0
Copy link
Member

saig0 commented Jan 3, 2025

Successfully created backport PR for 1.17:

@saig0
Copy link
Member

saig0 commented Jan 3, 2025

Successfully created backport PR for 1.18:

@saig0
Copy link
Member

saig0 commented Jan 3, 2025

Successfully created backport PR for 1.19:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lower log level of Feel engine creation statement
2 participants